fix: refactoring book loas serializers

api/loans/serializers.py

@@ -29,29 +29,9 @@ class BookLoanSerializer(serializers.ModelSerializer):
             time_string += f" {minutes} mins"
 
         data["remaining_loan_time"] = time_string + " days left"
-        return data
-
-    class Meta:
-        model = BookLoan
-        fields = "__all__"
-
-
-class MemberLoanSerializer(BookLoanSerializer):
-    book_detail = BookSerializer(source="book", read_only=True)
-    is_overdue = serializers.BooleanField(read_only=True)
-
-    def to_representation(self, instance):
-        data = super().to_representation(instance)
         data["is_overdue"] = instance.due_date < timezone.now()
         return data
 
     class Meta:
         model = BookLoan
-        fields = [
-            "book",
-            "book_detail",
-            "member",
-            "loan_date",
-            "due_date",
-            "is_overdue",
-        ]
+        fields = "__all__"

api/loans/views.py

@@ -4,7 +4,7 @@ from rest_framework.response import Response
 from rest_framework.filters import SearchFilter
 from django_filters.rest_framework import DjangoFilterBackend
 
-from .serializers import BookLoan, BookLoanSerializer, MemberLoanSerializer
+from .serializers import BookLoan, BookLoanSerializer
 from ..auth.permissions import IsNotStaffUser, IsStaffUser
 
 
@@ -53,7 +53,7 @@ class UpComingBookLoanViewSet(BookLoanViewSet):
 class MemberLoanViewSet(BookLoanViewSet):
     permission_classes = [IsNotStaffUser]
     queryset = BookLoan.objects.all()
-    serializer_class = MemberLoanSerializer
+    serializer_class = BookLoanSerializer
 
     def get_queryset(self):
         member_id = self.kwargs.get("member_id")